On Mon, Apr 15, 2024 at 9:46 PM Amit Langote <amitlangot...@gmail.com> wrote: > On Sat, Apr 13, 2024 at 11:12 PM jian he <jian.universal...@gmail.com> wrote: > > On Fri, Apr 12, 2024 at 5:44 PM Amit Langote <amitlangot...@gmail.com> > > wrote: > > > > > > > elog(ERROR, "unrecognized json wrapper %d", wrapper); > > > > should be > > > > elog(ERROR, "unrecognized json wrapper %d", (int) wrapper); > > > > > > Fixed in 0003. > > > > > the fix seems not in 0003? > > other than that, everything looks fine.
Oops, really fixed now in 0002. > I've combined these patches into one -- attached 0001. Will push tomorrow. Decided to break the error message improvement patch into its own after all -- attached 0001. > Now studying the JsonBehavior DEFAULT expression issue and your patch. I found some more coercion-related expression nodes that must also be checked along with CoerceViaIO and CoerceToDomain. Also, after fixing the code to allow them, I found that we'd need to also check recursively whether their argument expression is also one of the supported expression nodes. Also, I decided that it's not necessary to include "cast" in the error message as one of the supported expressions. Will push all today. -- Thanks, Amit Langote
v5-0002-SQL-JSON-Miscellaneous-fixes-and-improvements.patch
Description: Binary data
v5-0001-SQL-JSON-Improve-some-error-messages.patch
Description: Binary data
v5-0003-SQL-JSON-Fix-issues-with-DEFAULT-.-ON-ERROR-EMPTY.patch
Description: Binary data
