On Mon, Apr 22, 2024 at 5:57 AM Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > On Friday, April 19, 2024 10:54 AM Kuroda, Hayato/黒田 隼人 > <kuroda.hay...@fujitsu.com> wrote: > > In your patch, the pg_dump.c was updated. IIUC the main reason was that > > pg_restore executes some queries as single transactions so that ALTER > > SUBSCRIPTION cannot be done, right? > > Yes, and please see below for other reasons. > > > Also, failover was synchronized only when we were in the upgrade mode, but > > your patch seems to remove the condition. Can you clarify the reason? > > We used ALTER SUBSCRIPTION in upgrade mode because it was not allowed to use > connect=false and failover=true together when CREATE SUBSCRIPTION. But since > we > don't have this restriction anymore(we don't alter slot when creating sub > anymore), we can directly specify failover in CREATE SUBSCRIPTION and do that > in non-upgrade mode as well. > > Attach the V3 patch which also addressed Shveta[1] and Bertrand[2]'s comments.
Tested the patch, works well. thanks Shveta
