On Thu, May 9, 2024 at 10:13 PM Heikki Linnakangas <hlinn...@iki.fi> wrote: > > On 09/05/2024 16:12, Xing Guo wrote: > > Hi hackers, > > > > After several refactoring iterations, auxiliary processes are no > > longer initialized from the bootstrapper. I think using the > > InitProcessing mode for initializing auxiliary processes is more > > appropriate. > > At first I was sure this was introduced by my refactorings in v17, but > in fact it's been like this forever. I agree that InitProcessing makes > much more sense. The ProcessingMode variable is initialized to > InitProcessing, so I think we can simply remove that line from > AuxiliaryProcessMainCommon(). There are existing > "SetProcessingMode(InitProcessing)" calls in other Main functions too > (AutoVacLauncherMain, BackgroundWorkerMain, etc.), and I think those can > also be removed.
Good catch! I agree with you. Best Regards, Xing.
From 210e97c88fd49853d2a6304763ef7e8ad65e1b79 Mon Sep 17 00:00:00 2001 From: Xing Guo <higuox...@gmail.com> Date: Thu, 9 May 2024 20:57:48 +0800 Subject: [PATCH v2] Remove redundant SetProcessingMode(InitProcessing) calls. After several refactoring iterations, auxiliary processes are no longer initialized from the bootstrapper. Using the InitProcessing mode for initializing auxiliary processes is more appropriate. Since the global variable Mode is initialized to InitProcessing, we can remove redundant calls of SetProcessingMode(InitProcessing). --- src/backend/postmaster/autovacuum.c | 4 ---- src/backend/postmaster/auxprocess.c | 1 - src/backend/postmaster/bgworker.c | 2 -- src/backend/replication/logical/slotsync.c | 2 -- src/backend/tcop/postgres.c | 2 -- 5 files changed, 11 deletions(-) diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c index 9a925a10cd..5a1cfabf19 100644 --- a/src/backend/postmaster/autovacuum.c +++ b/src/backend/postmaster/autovacuum.c @@ -380,8 +380,6 @@ AutoVacLauncherMain(char *startup_data, size_t startup_data_len) if (PostAuthDelay) pg_usleep(PostAuthDelay * 1000000L); - SetProcessingMode(InitProcessing); - /* * Set up signal handlers. We operate on databases much like a regular * backend, so we use the same signal handling. See equivalent code in @@ -1373,8 +1371,6 @@ AutoVacWorkerMain(char *startup_data, size_t startup_data_len) MyBackendType = B_AUTOVAC_WORKER; init_ps_display(NULL); - SetProcessingMode(InitProcessing); - /* * Set up signal handlers. We operate on databases much like a regular * backend, so we use the same signal handling. See equivalent code in diff --git a/src/backend/postmaster/auxprocess.c b/src/backend/postmaster/auxprocess.c index 78f4263eeb..0faf7df0b6 100644 --- a/src/backend/postmaster/auxprocess.c +++ b/src/backend/postmaster/auxprocess.c @@ -54,7 +54,6 @@ AuxiliaryProcessMainCommon(void) init_ps_display(NULL); - SetProcessingMode(BootstrapProcessing); IgnoreSystemIndexes = true; /* diff --git a/src/backend/postmaster/bgworker.c b/src/backend/postmaster/bgworker.c index cf64a4beb2..5bbe02bbc3 100644 --- a/src/backend/postmaster/bgworker.c +++ b/src/backend/postmaster/bgworker.c @@ -746,8 +746,6 @@ BackgroundWorkerMain(char *startup_data, size_t startup_data_len) MyBackendType = B_BG_WORKER; init_ps_display(worker->bgw_name); - SetProcessingMode(InitProcessing); - /* Apply PostAuthDelay */ if (PostAuthDelay > 0) pg_usleep(PostAuthDelay * 1000000L); diff --git a/src/backend/replication/logical/slotsync.c b/src/backend/replication/logical/slotsync.c index f1f44d41ef..72857694a5 100644 --- a/src/backend/replication/logical/slotsync.c +++ b/src/backend/replication/logical/slotsync.c @@ -1342,8 +1342,6 @@ ReplSlotSyncWorkerMain(char *startup_data, size_t startup_data_len) init_ps_display(NULL); - SetProcessingMode(InitProcessing); - /* * Create a per-backend PGPROC struct in shared memory. We must do this * before we access any shared memory. diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index 2dff28afce..4b2de1dc70 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -4161,8 +4161,6 @@ PostgresMain(const char *dbname, const char *username) Assert(dbname != NULL); Assert(username != NULL); - SetProcessingMode(InitProcessing); - /* * Set up signal handlers. (InitPostmasterChild or InitStandaloneProcess * has already set up BlockSig and made that the active signal mask.) -- 2.45.0
