On Wed, May 15, 2024 at 04:07:18PM -0400, Robert Haas wrote: > On Wed, May 15, 2024 at 3:30 PM Nathan Bossart <nathandboss...@gmail.com> > wrote: >> This is much cleaner, thanks. The only thing that stands out to me is that >> the "once per release cycle" section should probably say to do an indent >> run after downloading the typedef file. > > How's this?
I compared this with my v1, and the only bit of information there that I see missing in v3 is that validation step 4 only applies in the once-per-cycle run (or if you forget to pgindent before committing a patch). This might be why I was struggling to untangle the two types of pgindent runs in my attempt. Perhaps it's worth adding a note to that step about when it is required. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
