On Wed, May 15, 2024 at 11:48 PM Andres Freund <and...@anarazel.de> wrote: > On 2024-05-15 10:38:20 +0200, Alvaro Herrera wrote: > > I disagree with this. IMO the impact of the Sawada/Naylor change is > > likely to be enormous for people with large tables and large numbers of > > tuples to clean up (I know we've had a number of customers in this > > situation, I can't imagine any Postgres service provider that doesn't). > > The fact that maintenance_work_mem is no longer capped at 1GB is very > > important and I think we should mention that explicitly in the release > > notes, as setting it higher could make a big difference in vacuum run > > times. > > +many.
TIDStore/the lifting of the maintenance_work_mem cap is likely to make the performance of VACUUM a lot more predictable, overall. While most VACUUM operations don't hit the limit, the limit is disproportionately involved in cases where (for whatever reason) vacuuming becomes a long and painful process. Even if you as a user never run into such a problem, you still spend time worrying about it, and/or taking measures to make sure it doesn't affect you. The justification for not including mention of these items is that they're not very relevant to users. I find that hard to square with what does get included. For example, the "Source Code" section is full of highly niche items. Items that are low impact, even for users that'll benefit the most. Also, "Monitoring" often mentions monitoring improvements that expose low-level implementation details (e.g. SLRU statistics), even though there's a good chance that Bruce wouldn't include an item for some improvement to the SLRU subsystem itself. If somebody puts in an enormous amount of effort to get a big performance improvement over the line, then ISTM that that effort is a useful signal when the time comes to write the release notes (at least up to a point). For example, Masahiko and John spent about 2 years on the TIDStore thing, on and off. These things do not happen in a vacuum (no pun intended). Common sense tells me that they went to those lengths precisely because they understood that it very much was relevant to users. That belief would have been reinforced by both experience, and by discussion on the list during the development of the feature. To be fair to Bruce, it probably really is true that most individual users won't care about (say) TIDStore. But it's probably also true that most individual users don't care about the release notes, or at most skim the major items. -- Peter Geoghegan
