On Sun, Sep 12, 2021 at 8:43 PM vignesh C <vignes...@gmail.com> wrote:
>
> Thanks for the changes, the suggested changes make the parsing code
> simpler. I have merged the changes to the main patch. Attached v27
> patch has the changes for the same.
>

+pubobj_name: ColId { $$ = list_make1(makeString($1)); }
+ | ColId indirection { $$ = lcons(makeString($1), $2); }
  ;

I think "ColId indirection" should handle catalog and schema name as
we are doing in qualified_name. See attached (this can be applied atop
v27-0002). The one other improvement we can do here is to extract the
common code from qualified_name (especially for "ColId indirection")
and pubobj_name. What do you think?

-- 
With Regards,
Amit Kapila.

Attachment: v28-0003-Include-catalog-name-and-schema-name-in-rangevar.patch
Description: Binary data

Reply via email to