Hi,

On 2021-09-07 14:44:39 -0500, Justin Pryzby wrote:
> On Tue, Sep 07, 2021 at 12:27:27PM -0700, Andres Freund wrote:
> > I think this is a tad too strong. We should continue to clean up on exit as
> > long as the error didn't happen while we're already inside llvm
> > code. Otherwise we loose some ability to find leaks. How about checking in 
> > the
> > error path whether fatal_new_handler_depth is > 0, and skipping cleanup in
> > that case? Because that's precisely when it should be unsafe to reenter
> > LLVM.

The more important reason is actually profiling information that needs to be
written out.

I've now pushed a fix to all relevant branches. Thanks all!

Regards,

Andres



Reply via email to