On Tue, Sep 26, 2017 at 9:13 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > I wrote: >> Rather than dig into the guts of glibc to find that out, though, I think >> we should just s/fallocate/posix_fallocate/g on this patch. The argument >> for using the former seemed pretty thin to begin with. > > Pushed with that change; we'll soon see what the buildfarm thinks.
Thanks. > I suspect that the provisions for EINTR and ENOSYS errors may now be > dead code, since the Linux man page for posix_fallocate mentions > neither. They're not much code though, and POSIX itself *does* > list EINTR, so I'm hesitant to muck with that. Ah, it all makes sense now that I see the fallback strategy section of the posix_fallocate() man page. I was unaware that there were kernel releases that had the syscall but lacked support in tmpfs. Thanks for testing and fixing that. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers