On Fri, Oct 6, 2017 at 7:04 PM, Dilip Kumar <dilipbal...@gmail.com> wrote: > On Fri, Oct 6, 2017 at 6:36 PM, Robert Haas <robertmh...@gmail.com> wrote: >> On Fri, Oct 6, 2017 at 2:12 AM, Dilip Kumar <dilipbal...@gmail.com> wrote: >>>> The performance results look good, but that's a slightly different >>>> thing from whether the estimate is accurate. >>>> >>>> + nbuckets = tbm_calculate_entires(maxbytes); >>>> >>>> entires? >>> >>> changed to >>> + tbm->maxentries = (int) tbm_calculate_entires(maxbytes); >> >> My point was not that you should add a cast, but that you wrote >> "entires" rather than "entries". > > My bad, I thought you were suggesting the variable name as "entries" > instead of "nbuckets" so I removed the variable "nbuckets". I will > fix the typo in the function name and post the patch.
Fixed in the attached version. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
improve_bitmap_cost_v5.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
