Reviewed-by: Jose Fonseca <jfons...@vmware.com> I assume that PIGLIT_GL_VISUAL_RGBA came from GLUT_RGBA, but given that it is a misleading alias for PIGLIT_GL_VISUAL_RGB and there is no need to be bug compatible with glut, I believe that in a follow on change we should eliminate PIGLIT_GL_VISUAL_RGBA alias, so that test writers can immediately notice that they need to add PIGLIT_GL_VISUAL_ALPHA when they want it.
Jose ----- Original Message ----- > Note that PIGLIT_GL_VISUAL_RGB == PIGLIT_GL_VISUAL_RGBA so the > later doesn't necessarily get a window with an alpha channel. > Need to add the PIGLIT_GL_VISUAL_ALPHA flag. > > Fixes http://bugs.freedesktop.org/show_bug.cgi?id=59872 > > v2: fix commit message > --- > .../depth_texture_mode_and_swizzle.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git > a/tests/spec/ext_texture_swizzle/depth_texture_mode_and_swizzle.c > b/tests/spec/ext_texture_swizzle/depth_texture_mode_and_swizzle.c > index d0d0270..1adede4 100644 > --- a/tests/spec/ext_texture_swizzle/depth_texture_mode_and_swizzle.c > +++ b/tests/spec/ext_texture_swizzle/depth_texture_mode_and_swizzle.c > @@ -45,7 +45,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN > > config.window_width = 170; > config.window_height= 30; > - config.window_visual = PIGLIT_GL_VISUAL_RGBA | > PIGLIT_GL_VISUAL_DOUBLE; > + config.window_visual = PIGLIT_GL_VISUAL_RGB | > PIGLIT_GL_VISUAL_ALPHA | PIGLIT_GL_VISUAL_DOUBLE; > > PIGLIT_GL_TEST_CONFIG_END > > -- > 1.7.3.4 > > _______________________________________________ > Piglit mailing list > Piglit@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/piglit > _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit