On Sun, 2009-07-19 at 12:04 +0200, Joey Hess wrote:
> Hello, I think I am seeing the same bug, on one machine
> (a xen domU running 2.6.18-6-xen-amd64 and Debian unstable userland FWIW):
[...]
> This kernel is too old to have a /dev/fd. But, your use of /dev/fd is
> completly unnecessary anyway. You already have an open $fh, so just
> point OUT_MBOX at it:
> 
> -open (OUT_MBOX, ">/dev/fd/" . fileno($fh))
> +open(OUT_MBOX, ">&", $fh);
> 
> Works for me. Note that bts contains the idiom in two places.

Hmmm, good point; thanks.

Alexander, could you please try the following diff (against the current
unstable package) and see if it fixes the issue you were seeing?

Index: scripts/bts.pl
===================================================================
--- scripts/bts.pl      (revision 1918)
+++ scripts/bts.pl      (working copy)
@@ -2881,7 +2881,7 @@
                                       DIR => File::Spec->tmpdir,
                                       UNLINK => 1);
            # Use filehandle for security
-           open (OUT_MBOX, ">/dev/fd/" . fileno($fh))
+           open (OUT_MBOX, ">&", $fh)
                or die "bts: writing to temporary file: $!\n";
        } else {
            $filename = $mboxfile;
@@ -3287,7 +3287,7 @@
                                              UNLINK => 1);
 
                # Use filehandle for security
-               open (OUT_LIVE, ">/dev/fd/" . fileno($fh))
+               open (OUT_LIVE, ">&", $fh)
                    or die "bts: writing to temporary file: $!\n";
                # Correct relative urls to point to the bts.
                $live =~ s%\shref="(?:/cgi-bin/)?(\w+\.cgi)% 
href="$btscgiurl$1%g;

Regards,

Adam




-- 
To unsubscribe, send mail to pkg-devscripts-unsubscr...@teams.debian.net.

Reply via email to