Hi, On Mon, 2009-11-30 at 14:53 +0000, Iain Lane wrote: > On Mon, Nov 30, 2009 at 01:37:28PM -0000, Adam D. Barratt wrote: > >bts already contains code to add "thanks" to the end of a mail if > >it's called in "force-interactive" mode, which is intended for the > >case where you want to force editing of the body before sending; see > >addfooter(). > > > >If "thanks" is added in other circumstances, that should be by > >modifying the condition in the existing code. I believe that last > >time we discussed doing so automagically under non-force-interactive > >conditions (while implementing #474205) the consensus was that it > >wasn't useful, but that was 18 months ago so people may well have > >changed their minds. :-) > > (Outlook Express?! :)
When I'm mailing from my work machine, yeah :) (mainly for hysterical raisins) > Hm. Is there a case when 'thanks' would cause harm? Seems to me that > adding it all the time would be safe, and would mean that users wouldn't > have to think about whether it was necessary. I didn't notice the > force-interactive stuff, so obviously my patch needs reworking in light > of that (if you agree that this is reasonable). The only potential issue I can see is making sure that we don't add the text more than once. For non-interactive use, that's obviously not an issue as the string can simply be appended to the body, and the force-interactive case is already handled. [time passes and I get distracted by dinner] Looking at the code, I've forgotten what the condition was that I thought might prove "interesting" for the simple interactive case. tbh, I think adapting addfooter() to always add the text but only include the signature for force-interactive would probably suffice. Regards, Adam -- To unsubscribe, send mail to pkg-devscripts-unsubscr...@teams.debian.net.
