On Mon, Apr 11, 2011 at 08:04:06AM +0400, Dmitry Kurochkin wrote: > Hi James. > > On Sun, 10 Apr 2011 23:51:36 -0400, James Vega <james...@debian.org> wrote: > > On Tue, Apr 05, 2011 at 04:19:39AM +0400, Dmitry Kurochkin wrote: > > > The Apache license rexex in licensecheck version 2.10.71 is: > > > > > > /under the Apache License, Version ([^ ]+) \(the License\)/ > > > > > > Since the stuff in parenthesis is meant for the following text which may > > > not be present in many customized preambles, it should not be matched for. > > > > Have you seen instances where that was the problem? > > Yes, the polygraph [1] package I am trying to get accepted to Debian. > See discussion on the debian-mentors mailing list [2].
Thanks for the pointer. > > It seems like the > > more relevant problem is that the regular expression doesn't contain the > > double quotes around "License", like official boilerplate does. > > > > The quotes are missing indeed. But apparently licensecheck does some > preprocessing on the input because the current regex successfully > matches the official boilerplate. Ah, right. We strip out everything except a basic set of characters to ease matching. > This may not be the most relevant problem, but we have at least one > example when it would help. And since fixing the issue is easy, I > believe it should be done. Yeah, it's just a balance between being flexible enough to catch variations but not too flexible that there are significant false positives. If it had been an issue with the quoting, I would have preferred to fix that instead. Seeing as that isn't an issue and the modified check isn't too broad, I'll fix it. Thanks for the suggestion. :) -- James GPG Key: 1024D/61326D40 2003-09-02 James Vega <james...@debian.org>
signature.asc
Description: Digital signature
