Control: severity -1 serious
Control: tags -1 + patch
On Tue, 21 Aug 2018 at 20:19:31 +0100, Toby Speight wrote:
> * aptitude install libqt5gstreamer-dev
> * pkg-config --cflags Qt5GStreamer-1.0
>
> /--------
> | Package gstreamer-audio-1.0 was not found in the pkg-config search path.
...
> | Package 'gstreamer-audio-1.0', required by 'Qt5GStreamer-1.0', not found
> \--------
>
> This package should have a dependency (at least Recommends) on
> libgstreamer-plugins-base1.0-dev, otherwise its pkg-config file is
> unusable.
I noticed this bug report while looking at unrelated release-critical
bug #997252 in the same package.
This class of bug is generally considered to be release-critical,
although arguably it might not be RC for libqt5gstreamer-dev if the
functionality of libqt5gstreamer-dev is normally located via CMake and
only rarely via pkg-config (maintainers: please downgrade if the .pc
files are considered to be unimportant in this particular package).
The .pc files also depend on libraries from libglib2.0-dev and
libgstreamer1.0-dev; in practice those get pulled in by installing
libgstreamer-plugins-base1.0-dev, but for completeness it's probably best
to add them as Depends explicitly. I would suggest the attached patch.
Qt5GStreamerQuick-1.0.pc also depends on a library from
qtdeclarative5-dev, which the other pkg-config modules do not. Any
level of dependency relationship between Depends and Suggests could be
argued to be correct here, depending on whether use of
Qt5GStreamerQuick-1.0.pc is common, rare or somewhere in between.
In the attached patch I've gone for Recommends, but the package's
maintainers would know better what's appropriate here.
> Alternatively, perhaps the pc files need to be shuffled between packages?
I think they are in the correct package, it just needs more dependencies
as you said.
smcv
>From 90b010f806a3503754ae6c1ecc364b543e4985cf Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Fri, 22 Jul 2022 02:13:23 +0100
Subject: [PATCH] Add missing dependencies on GLib/GStreamer -dev packages
Without these, the pkg-config metadata is not usable.
qtdeclarative5-dev is only needed for Qt5GStreamerQuick-1.0.pc,
so is set as a Recommends here.
Closes: #906882
---
debian/control | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/debian/control b/debian/control
index 0810e80..18171d4 100644
--- a/debian/control
+++ b/debian/control
@@ -127,6 +127,9 @@ Package: libqt5gstreamer-dev
Section: libdevel
Architecture: any
Depends: libboost-dev (>= 1.39),
+ libglib2.0-dev,
+ libgstreamer-plugins-base1.0-dev (>= 1.1.90),
+ libgstreamer1.0-dev,
libqt5glib-2.0-0 (= ${binary:Version}),
libqt5gstreamer-1.0-0 (= ${binary:Version}),
libqt5gstreamerquick-1.0-0 (= ${binary:Version}),
@@ -134,6 +137,7 @@ Depends: libboost-dev (>= 1.39),
libqt5gstreamerutils-1.0-0 (= ${binary:Version}),
qtbase5-dev,
${misc:Depends}
+Recommends: qtdeclarative5-dev
Suggests: qtgstreamer-doc
Description: Development headers for QtGStreamer - Qt 5 build
QtGStreamer provides C++ bindings for GStreamer with a Qt-style API,
--
2.36.1
_______________________________________________
pkg-kde-extras mailing list
pkg-kde-extras@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-kde-extras
