On Sun, May 13, 2012 at 5:27 PM, Fabian Greffrath <fab...@greffrath.com> wrote: > Am Samstag, den 12.05.2012, 11:29 -0400 schrieb Andres Mejia: >> I just glanced over the changes to this. To be on the safer side, the >> symbols needed by handbrake and provided in audioconvert.c should be >> built from handbrake. This way, any internal changes made to libav for >> audioconvert won't break handbrake. > > IIRC, the only symbol from audioconvert.h that was actually needed was > struct AVAudioConvert, so I declared that myself and was ready with it. > Please compare with my patch from > <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/2012-February/024218.html>: > > --- handbrake-0.9.5.orig/libhb/decavcodec.c > +++ handbrake-0.9.5/libhb/decavcodec.c > @@ -62,7 +62,9 @@ > #include "hb.h" > #include "hbffmpeg.h" > #include "downmix.h" > -#include "libavcodec/audioconvert.h" > +//#include "libavcodec/audioconvert.h" > +struct AVAudioConvert; > +typedef struct AVAudioConvert AVAudioConvert; > > static int decavcodecInit( hb_work_object_t *, hb_job_t * ); > static int decavcodecWork( hb_work_object_t *, hb_buffer_t **, > hb_buffer_t ** ); > >
I prefer this patch. It's better than including all of audioconvert.h. Would you mind modifying handbrake packaging to use this patch instead? -- ~ Andres _______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers