Your message dated Sun, 29 Jul 2012 01:02:12 +0000
with message-id <e1svhtc-0008up...@franck.debian.org>
and subject line Bug#682361: fixed in supercollider 1:3.5.3~repack-3
has caused the Debian Bug report #682361,
regarding supercollider FTFBS on amel and armhf qreal VS double issues
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
682361: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682361
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: supercollider
Version: 1:3.5.3~repack-2
severity: serious
tags: patch

Your package failed to build on armel and armhf
[ 78%] Building CXX object 
lang/CMakeFiles/libsclang.dir/__/QtCollider/widgets/QcMultiSlider.cpp.o
cd "/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/obj-arm-linux-gnueabihf/lang" && /usr/bin/g++   -DSC_LINUX -DSC_DATA_DIR=\"/usr/share/SuperCollider\" -DYYSTACK_USE_ALLOCA 
-DHAVE_LID -DHAVE_WII -DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_CORE_LIB -DSC_QT -DQT_COLLIDER_EXPORTING -DQT_NO_KEYWORDS -DBUILDING_SUPERCOLLIDER -DHAVE_READLINE -DHAVE_ALSA=1 -DQT_NO_DEBUG -g -O2 -fstack-protector --param=ssp-buffer-size=4 
-Wformat -Werror=format-security -Wall -D_FORTIFY_SOURCE=2 -O2 -g -I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/include/common" 
-I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/include/lang" -I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/include/plugin_interface" 
-I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/include/server" 
-I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/external_libraries/boost_lockfree" 
-I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/external_libraries/threadpool" 
-I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/external_libraries/yaml-cpp-0.3.0/include" 
-I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/external_libraries/TLSF-2.4.6/src" 
-I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/lang/LangSource/Bison" -I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/SCDoc" 
-I/usr/include/qt4 -I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtCore -I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/include/QtCollider" 
-I"/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/lang/X11_INCLUDE_DIR"    -fschedule-insns2 -fomit-frame-pointer -Wreturn-type -fvisibility=hidden -pthread -o 
CMakeFiles/libsclang.dir/__/QtCollider/widgets/QcMultiSlider.cpp.o -c "/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp"
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:
 In member function 'virtual void QcMultiSlider::mousePressEvent(QMouseEvent*)':
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:187:47:
 error: no matching function for call to 'QcMultiSlider::valueRect(int, 
double&)'
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:187:47:
 note: candidate is:
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:152:7:
 note: QRect QcMultiSlider::valueRect(int, qreal&)
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:152:7:
 note:   no known conversion for argument 2 from 'double' to 'qreal& {aka 
float&}'
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:
 In member function 'virtual void QcMultiSlider::mouseMoveEvent(QMouseEvent*)':
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:231:45:
 error: no matching function for call to 'QcMultiSlider::valueRect(int, 
double&)'
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:231:45:
 note: candidate is:
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:152:7:
 note: QRect QcMultiSlider::valueRect(int, qreal&)
/build/buildd-supercollider_3.5.3~repack-2-armhf-CT3rf6/supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp:152:7:
 note:   no known conversion for argument 2 from 'double' to 'qreal& {aka 
float&}'
make[3]: *** 
[lang/CMakeFiles/libsclang.dir/__/QtCollider/widgets/QcMultiSlider.cpp.o] Error 
1


On most architectures qreal is defined as double but on arm architectures
it is defined as float. Assignments between qreal and double are ok because
assignments between float and double are ok but there can be issues with
pointers, reference parameters, templates and overloaded functions if proper distinctions are not made. In this particular case the issue is a reference parameter.

The fix is simple enough, just a couple of variable definitions that need
changing.

I've updated arm-qreal-is-float.patch to fix this issue.



From: Felipe Sateler <fsate...@debian.org>
Date: Mon, 9 Jul 2012 18:57:51 -0400
Subject: [PATCH] QcMultiSlider::valueRect takes in a qreal, not a double

Usually qreal is double (which is why it works), but on ARM systems qreal
is float instead.
This causes sc to fail to build on ARM systems.

---

There is a similar problem with some reference parameters in QcMultislider
.cpp which I have added the fix for to this patch -- Peter Green

---
 QtCollider/widgets/QcMultiSlider.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.h
===================================================================
--- supercollider-3.5.3~repack.orig/QtCollider/widgets/QcMultiSlider.h	2012-06-23 21:38:01.000000000 +0000
+++ supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.h	2012-07-21 21:18:44.000000000 +0000
@@ -109,7 +109,7 @@
     void setStartIndex( int i ) { startIndex = qBound(0, i, _values.count()-1); update(); }
 
     QRect contentsRect();
-    QRect valueRect( int count, double & spacing );
+    QRect valueRect( int count, qreal & spacing );
     inline float valueFromPos( float pos, float range );
     inline void setValue( int index, double value );
     double rounded ( double value );
Index: supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp
===================================================================
--- supercollider-3.5.3~repack.orig/QtCollider/widgets/QcMultiSlider.cpp	2012-06-23 21:38:01.000000000 +0000
+++ supercollider-3.5.3~repack/QtCollider/widgets/QcMultiSlider.cpp	2012-07-21 23:21:44.000000000 +0000
@@ -182,7 +182,7 @@
   if( !c ) return;
 
   bool horiz = ort == Qt::Horizontal;
-  double spacing;
+  qreal spacing;
 
   QRect r( valueRect( c - startIndex, spacing ) );
 
@@ -226,7 +226,7 @@
     return;
   }
 
-  double xStep;
+  qreal xStep;
 
   QRect r( valueRect( c - startIndex, xStep ) );
 

--- End Message ---
--- Begin Message ---
Source: supercollider
Source-Version: 1:3.5.3~repack-3

We believe that the bug you reported is fixed in the latest version of
supercollider, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 682...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Felipe Sateler <fsate...@debian.org> (supplier of updated supercollider package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 28 Jul 2012 20:19:58 -0400
Source: supercollider
Binary: supercollider supercollider-common supercollider-server 
supercollider-supernova libscsynth1 supercollider-dev supercollider-emacs 
supercollider-vim supercollider-gedit
Architecture: source all amd64
Version: 1:3.5.3~repack-3
Distribution: unstable
Urgency: low
Maintainer: Debian Multimedia Packages Maintainers 
<pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Felipe Sateler <fsate...@debian.org>
Description: 
 libscsynth1 - SuperCollider synthesis server library
 supercollider - real time audio synthesis programming language
 supercollider-common - common files for SuperCollider
 supercollider-dev - development files for SuperCollider
 supercollider-emacs - SuperCollider mode for Emacs
 supercollider-gedit - SuperCollider mode for Gedit
 supercollider-server - real time audio synthesis server
 supercollider-supernova - real time audio synthesis server (multiprocessor 
version)
 supercollider-vim - SuperCollider mode for Vim
Closes: 682361
Changes: 
 supercollider (1:3.5.3~repack-3) unstable; urgency=low
 .
   * Avoid FTBFS in PowerPC
   * Avoid FTBFS in ia64
   * Fix ARM FTBFS: more qreal->double assumptions. Closes: #682361
Checksums-Sha1: 
 8b3c4039ef31b5c30a3a08ce3fc52bb93dda0053 3214 supercollider_3.5.3~repack-3.dsc
 b3ed1e32483666698d1202996e6e4a9bb99e0275 70522 
supercollider_3.5.3~repack-3.debian.tar.gz
 365875b40f3632a5841de2cedea1136a9a30ed6d 2710032 
supercollider-common_3.5.3~repack-3_all.deb
 0103bd81f428dfe78b644a538b2848f9e18b4f68 91854 
supercollider-emacs_3.5.3~repack-3_all.deb
 92b3ed583a71e47a68858d05d02db8f9a3764dcc 63700 
supercollider-vim_3.5.3~repack-3_all.deb
 6ecbee90722c64137c28f07efdc1935f61a45b59 46078 
supercollider-gedit_3.5.3~repack-3_all.deb
 68d7a4d84ee6587bcc793e5421a27f804531b3d4 866668 
supercollider_3.5.3~repack-3_amd64.deb
 003b8743f4bbc4b7db7a537517bf729d4d6ba604 492908 
supercollider-server_3.5.3~repack-3_amd64.deb
 0e7a88a300ba30815e4c023c624875cc47ec424a 809718 
supercollider-supernova_3.5.3~repack-3_amd64.deb
 230d61ff908329fb69335a65ec58b1f444a80df2 169108 
libscsynth1_3.5.3~repack-3_amd64.deb
 b914bb04c1381c4716350571591451463fee59ee 91094 
supercollider-dev_3.5.3~repack-3_amd64.deb
Checksums-Sha256: 
 a3d91fc19ad6f1605c62cc1df47c88dc57353d7d8187b97b9b9c19ab54e8a2c6 3214 
supercollider_3.5.3~repack-3.dsc
 53db87f84ef55bc72210c3a22e17d62b9af90b63561041a24a625fca12739b6f 70522 
supercollider_3.5.3~repack-3.debian.tar.gz
 b29cfb1b724a786341f5d5dc7f20ffd4cd5c2ee990329768fc037c4279706f4e 2710032 
supercollider-common_3.5.3~repack-3_all.deb
 f189fb50f683551cb00983aa68eb0cfac31b7c14f392c256a77b3099aedc23bc 91854 
supercollider-emacs_3.5.3~repack-3_all.deb
 b9fa074fe81d503dd318aeb7c92e5716a35cf4000edecd572ecbe99f523f68e6 63700 
supercollider-vim_3.5.3~repack-3_all.deb
 b0acd51a1003aa287bbe01a245fab38b66629f278726183df2a59b1ad49bb9d9 46078 
supercollider-gedit_3.5.3~repack-3_all.deb
 887331215b2621318b04aae17a74f7189f449cac5c1b73331c8baf609fb9f0ba 866668 
supercollider_3.5.3~repack-3_amd64.deb
 3252ca249f68870f786c463ae9fbf8a9cbdf64252370f45fd9ebfbac25f1fc3b 492908 
supercollider-server_3.5.3~repack-3_amd64.deb
 6d62c900b68859d4aef980c75ad7494beffb48bf6021c71492b933fd0bb450ca 809718 
supercollider-supernova_3.5.3~repack-3_amd64.deb
 3b87524bfc8b3a5c9dabac818c8796724798fa1ab86e9211d8c832981bc5cdff 169108 
libscsynth1_3.5.3~repack-3_amd64.deb
 d9e531819e9cf73afa2a18315cb43d62ac79cb8f48d9f04f5b08d6bb8f5b4bee 91094 
supercollider-dev_3.5.3~repack-3_amd64.deb
Files: 
 845a1d36ae2e7701137871b7ae085a90 3214 sound optional 
supercollider_3.5.3~repack-3.dsc
 f8670915db457225a693039f67352a58 70522 sound optional 
supercollider_3.5.3~repack-3.debian.tar.gz
 08204aa95d7244efb47ca5bec607f6e5 2710032 sound optional 
supercollider-common_3.5.3~repack-3_all.deb
 5bdea75ebfde1e3ab062cf9be3b3b630 91854 sound optional 
supercollider-emacs_3.5.3~repack-3_all.deb
 dd4794772f1453a3146ad4b7aa7e4481 63700 sound optional 
supercollider-vim_3.5.3~repack-3_all.deb
 f48ae2d3398684de80a07f8bf8e5346e 46078 sound optional 
supercollider-gedit_3.5.3~repack-3_all.deb
 b2a96ceec8dbe09087dbeb9e38cc0833 866668 sound optional 
supercollider_3.5.3~repack-3_amd64.deb
 0933ccf192f4b1a9a51c69795df14cae 492908 sound optional 
supercollider-server_3.5.3~repack-3_amd64.deb
 20cfe2580154a597d82ba45b9c758421 809718 sound optional 
supercollider-supernova_3.5.3~repack-3_amd64.deb
 1ba00e20551a4628814bb8b15a5149fd 169108 sound optional 
libscsynth1_3.5.3~repack-3_amd64.deb
 86d9e5edc7c7e2415c8a6cb549d09330 91094 sound optional 
supercollider-dev_3.5.3~repack-3_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQFIPAAAoJEKO6uuJAjdbPMsQP/0/fJyWVg8FAKk5fjhlx+rbD
oSdY1HRpuureIvxQQ+86xmo3QnMjKQ9BUPw/xp2c0fFEcv+YQ6WmhaSBeDSknAqN
qDKeDEblMbkBR+y+/RGQXL5GSuCx7nggp8kK5Ro9DcQY+aSx9xXC8XwkpGlSitDx
0fXgXcUjnfMeuYu2by0sjXkJcorIkMeTzxY+r6Y2DAKh57hbz3+Jg/ogyNTrKPi6
nuZJAbrE4bEwnlSevzVcsFDTotx+lBo+Y7ahsjYAB0l47VXmYPykQh4sIsIIB+eu
bI3gByBEhe6zfg4pYEC9c8X13oy1F9+sSWf0kbzV50/sgMY5pO4y5dTKfBynufxQ
07dgInPB5rUmUTdB22sbhEXmoxvQP43wuXo+YP1g3ye9XZvELNXRy23600/bhay5
4KPA238ckp+raHZbvp5qfksCw9xrRSe86YrfUwvdFL4B50thj0JDlJngwOVGK0Kv
QnOeWm64YC/mUHyViAeQaWoIHlMMOVa9aNrySrIn8rCmHWpwShTjh3qhQ2WeVjhS
nK4y7/Ou5EG7wWGRbdftGOPAyuFKbohozIjy2xkEY4OPpfIhZWDveiQIDv5fbAAm
s8ErTdkzVvADnFOrG3jUr2TAcFQGDkstrJC8lU9XMYGvD5yHcf+ZuGPYkka5SaPJ
5x5gOrtXwzS6VOh1XhNt
=8bEZ
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to