On 2014-02-16 22:50:40, Andrew Kelley wrote: > Thank you for your feedback. I have addressed everything so far (in my own > repository).
Looks good. Some comments on d/copyright: Please just use the short name and not MIT License (Expat). For Modified BSD License this is BSD-3-clause. You can also just mention the full text of Expat once in a stand-alone License paragraph. Also note that the order matters. Currently the first two paragraphs have no effect and everything has Copyright 2011 Jan Kokemüller and is licensed under Expat: "Multiple Files paragraphs are allowed. The last paragraph that matches a particular file applies to it. More general paragraphs should therefore be given first, followed by more specific overrides." (from CF-1.0) For example, d/copyright could look like the following: Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: libebur128 Source: https://github.com/jiixyj/libebur128 Files: * Copyright: 2011 Jan Kokemüller License: Expat Files: ebur128/queue/sys/queue.h Copyright: 1991, 1993 The Regents of the University of California License: BSD-3-clause full text of the license here Files: debian/* Copyright: 2014 Andrew Kelley License: Expat License: Expat full text of the license here > > There are warnings during the build: > > > > dpkg-shlibdeps: warning: symbol tan used by > > debian/libebur128-1/usr/lib/libebur128.so.1.0.1 found in none of the > > libraries > > dpkg-shlibdeps: warning: symbol pow used by > > debian/libebur128-1/usr/lib/libebur128.so.1.0.1 found in none of the > > libraries > > dpkg-shlibdeps: warning: symbol log used by > > debian/libebur128-1/usr/lib/libebur128.so.1.0.1 found in none of the > > libraries > > > > libebur128 needs to be linked against -lm. > > > > I submitted an upstream patch to fix this: > https://github.com/jiixyj/libebur128/pull/27 Please include the patch in the Debian package. Otherwise I'm happy with the package. A symbols file would be nice, but I can add that if you don't mind. Regards -- Sebastian Ramacher
signature.asc
Description: Digital signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers