Hi Guillem, On 30.06.2015 23:14, Andreas Cadhalpun wrote: > On 30.06.2015 21:40, Guillem Jover wrote: >> Perhaps, but the comment at >> <http://sources.debian.net/src/mpv/0.9.2-1%2Bffmpeg/common/av_log.c/#L229> >> was not very soothing, so that was one additional reason for the bug. :) > > Hmm, this comment is indeed a bit worrisome. > But I'm not sure I understand the reasoning given there. As far as I know > the accessor functions are only necessary for API that is not present > in Libav (in order to be ABI compatible after Libav merges, as the comment > says). So whether or not one uses the accessors shouldn't make a difference > for compatibility with Libav.
I've investigated this a bit more and it seems that the only potentially problematic FFmpeg-only API used by mpv is AVFrame->metadata, which mpv accesses via av_frame_get_metadata. [1] Thus I think the comment is just wrong and the warning should be removed. Best regards, Andreas 1: https://sources.debian.net/src/mpv/0.9.2-1%2Bffmpeg/video/filter/vf_lavfi.c/#L309 _______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
