2016-12-07 1:45 GMT+01:00 Jaromír Mikeš <mira.mi...@gmail.com>: > 2016-12-06 23:09 GMT+01:00 James Cowgill <jcowg...@debian.org>: >> On 06/12/16 02:15, Jaromír Mikeš wrote:
>> Why do you need to patch a makefile in? Most of this stuff could be done >> in debian/rules or by dh_install etc. > > I will move instructions from "my makefile" to d/rules file latter ... > for now I have just improved patch. > >>> +include build/general/Makefile.inc >> >> IMO you should use make recursion instead of including this makefile. > > I must investigate how to do properly ... not working here for now :( Fixed now in d/rules file. >>> +CFLAGS += -DNDEBUG -O3 -fPIC -ffast-math -ftree-vectorize -DUSE_PTHREADS >>> -Ibuild/linux/amd64 >> >> The headers in build/linux/amd64 look bundled so I don't think you >> should use them. > > Will be fixed ... need some time to figure out how to do it Used system-wide libatlas-dev headers >>> + gcc -shared $(LDFLAGS) -o $(QM-DSP_MAJ) -Wl,-soname,$(QM-DSP_MAJ) >>> -Wl,--whole-archive libqm-dsp.a -Wl,--no-whole-archive >> >> I think adding -Wl,--no-undefined is a good idea here. You then need to >> add the other libraries qm-dsp uses so you don't need to add them manually. > > Build fails with -Wl,--no-undefined :( > >>> + >>> +install: $(QM-DSP_MAJ) >>> + install -d $(DESTDIR)$(PREFIX)/include/base >>> + install -d $(DESTDIR)$(PREFIX)/$(LIBDIR) >>> + install -m 644 $(QM-DSP_H) $(DESTDIR)$(PREFIX)/include/base >> >> I think "/usr/include/base" is a bit too generic. I notice that fedora >> installs them into "/usr/include/qm-dsp". > > Hmmm but when building Ardour base/Pitch.h is searched ... > >> http://pkgs.fedoraproject.org/cgit/rpms/qm-dsp.git/tree/qm-dsp-install.patch Ahh ... sorry now I got it! :( All headers are now installed! Can you check now please? best regards mira _______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers