On 02/06/2018 10:21 AM, Joachim Bauch wrote: > Hi Sebastian, > > thanks for your feedback, I uploaded a new version to mentors: > https://mentors.debian.net/debian/pool/main/libh/libheif/libheif_0.0.1+20180206084258+git9d8f256-1.dsc > > Additional comments see below. > > On 03.02.2018 14:47, Sebastian Ramacher wrote: >> That fails to build: [...] > > Interesting, on Ubuntu the "string.h" seems to get pulled in by some > other header and it compiles fine.
well, in general "you" should explicitely include headers for the functions you need, rather than relying on "some other" header to do that for you - that other header might have required <string.h> internally but a newer version might have a different private implementation that allowed them to drop the include... > >> Some other issues: >> >> * The library package should be named based on the SONAME, so that would be >> libheif1. > > Changed to "libheif-1", or should the name be without the dash? the name should be "libheif1", without the dash. (the dash is usually used if you want multiple major versions of a library to be coinstallable, e.g. libheif1.0-2 and libheif3-1; urgh) > >> * Current Standards-Version is 4.1.3. > > Changed, however the lintian on mentors now complains that the version > is too new: "newer-standards-version 4.1.3 (current is 3.9.8)" seems like you have an old lintian on your system. (e.g. because you are building on a Debian/stretch machine in a sid-chroot; and/or because your machine hasn't been updated in a while) gfmdsr IOhannes
signature.asc
Description: OpenPGP digital signature
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
