Branch: refs/heads/pmd/7.0.x Home: https://github.com/pmd/pmd Commit: 378ba33f596e635fef8d762ec647d0a769a6e1c4 https://github.com/pmd/pmd/commit/378ba33f596e635fef8d762ec647d0a769a6e1c4 Author: Juan Martín Sotuyo Dodero <juansot...@gmail.com> Date: 2023-01-25 (Wed, 25 Jan 2023)
Changed paths: M pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseDiamondOperator.xml Log Message: ----------- Add failing test for UseDiamongOperatorRule - An IllegalStateException is produced when the inference context corresponds to an invocation of an unresolved method. - The rule effectively can't determine if the diamond oeprator can be used, but the current message of "overload resolution is not complete" is noisy, not actionable to the user (the issue is a missing class in the auxclasspath, not the overload resolution), and prevents the rule from continuing to analyze the current file. Commit: 8ef6042eb4931cefc12c3e5dffbf3bfc934643d3 https://github.com/pmd/pmd/commit/8ef6042eb4931cefc12c3e5dffbf3bfc934643d3 Author: Juan Martín Sotuyo Dodero <juansot...@gmail.com> Date: 2023-01-25 (Wed, 25 Jan 2023) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/UseDiamondOperatorRule.java Log Message: ----------- Suppress the overload resolution failure and continue - This is probably not the best solution (maybe the Infer logic needs to remove the check and handle it seamlessly?) but that code is too complex for me to make that call Commit: 869752bc342e44cf321fc98fcea96ec0159cd5ae https://github.com/pmd/pmd/commit/869752bc342e44cf321fc98fcea96ec0159cd5ae Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2023-01-25 (Wed, 25 Jan 2023) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/UseDiamondOperatorRule.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/types/internal/infer/ast/BaseInvocMirror.java Log Message: ----------- Shortcut equivalence check if ctdecl is unresolved Commit: 596cc2694d04bd2132aa05058551e01069c453cd https://github.com/pmd/pmd/commit/596cc2694d04bd2132aa05058551e01069c453cd Author: Juan Martín Sotuyo Dodero <juansot...@gmail.com> Date: 2023-01-25 (Wed, 25 Jan 2023) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/types/internal/infer/ast/BaseInvocMirror.java M pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseDiamondOperator.xml Log Message: ----------- Merge pull request #4357 from pmd/fix-usediamongoperator-rule [java] Fix IllegalStateException in UseDiamongOperator rule Compare: https://github.com/pmd/pmd/compare/74cbba5f61c9...596cc2694d04 _______________________________________________ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits