Hello, when building net/pktstat I get these warnings:
if cc -DHAVE_CONFIG_H -I. -I. -I. -DPATH_PKTSTATRC=\"/etc/pktstatrc\" -O2 -pipe -MT loop.o -MD -MP -MF ".deps/loop.Tpo" -c -o loop.o loop.c; then mv -f ".deps/loop.Tpo" ".deps/loop.Po"; else rm -f ".deps/loop.Tpo"; exit 1; fi In file included from loop.c:19: /usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside parameter list /usr/include/arpa/inet.h:74: warning: its scope is only this definition or declaration, which is probably not what you want /usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside parameter list if cc -DHAVE_CONFIG_H -I. -I. -I. -DPATH_PKTSTATRC=\"/etc/pktstatrc\" -O2 -pipe -MT sll.o -MD -MP -MF ".deps/sll.Tpo" -c -o sll.o sll.c; then mv -f ".deps/sll.Tpo" ".deps/sll.Po"; else rm -f ".deps/sll.Tpo"; exit 1; fi In file included from sll.c:21: /usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside parameter list /usr/include/arpa/inet.h:74: warning: its scope is only this definition or declaration, which is probably not what you want /usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside parameter list The attached diff seems to fix this. I sent this to rui@ (MAINTAINER) a few weeks ago, but didn't get any response so far. Regards, Markus
Index: Makefile =================================================================== RCS file: /cvs/ports/net/pktstat/Makefile,v retrieving revision 1.11 diff -u -p -r1.11 Makefile --- Makefile 12 Jul 2010 22:07:41 -0000 1.11 +++ Makefile 7 Sep 2010 13:18:22 -0000 @@ -2,7 +2,7 @@ COMMENT= network traffic viewer DISTNAME= pktstat-1.8.4 -REVISION= 0 +REVISION= 1 CATEGORIES= net HOMEPAGE= http://www.adaptive-enterprises.com.au/~d/software/pktstat/ Index: patches/patch-loop_c =================================================================== RCS file: patches/patch-loop_c diff -N patches/patch-loop_c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ patches/patch-loop_c 7 Sep 2010 13:18:22 -0000 @@ -0,0 +1,13 @@ +$OpenBSD$ +--- loop.c.orig Sat Nov 11 14:32:16 2006 ++++ loop.c Tue Sep 7 15:10:47 2010 +@@ -15,6 +15,9 @@ + #if HAVE_SYS_SOCKET_H + # include <sys/socket.h> + #endif ++#if HAVE_NETINET_IN_H ++# include <netinet/in.h> ++#endif + #if HAVE_ARPA_INET_H + # include <arpa/inet.h> + #endif Index: patches/patch-sll_c =================================================================== RCS file: patches/patch-sll_c diff -N patches/patch-sll_c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ patches/patch-sll_c 7 Sep 2010 13:18:22 -0000 @@ -0,0 +1,13 @@ +$OpenBSD$ +--- sll.c.orig Fri Nov 10 06:34:54 2006 ++++ sll.c Tue Sep 7 15:11:16 2010 +@@ -17,6 +17,9 @@ + #if HAVE_SYS_SOCKET_H + # include <sys/socket.h> + #endif ++#if HAVE_NETINET_IN_H ++# include <netinet/in.h> ++#endif + #if HAVE_ARPA_INET_H + # include <arpa/inet.h> + #endif
