Admittedly I whipped the patch for stable on a current machine using a stable
tree. So not tested.
If this solves the issue, then I am ok with it.
Ian McWilliam
________________________________________
From: owner-po...@openbsd.org [owner-po...@openbsd.org] on behalf of Jeremie
Courreges-Anglas [j...@wxcvbn.org]
Sent: Tuesday, 14 February 2017 9:20 PM
To: alexmcwhir...@triadic.us
Cc: Ian McWilliam; ports@openbsd.org; vsan...@foretell.ca
Subject: Re: Samba 4.4.9 OpenBSD 6.0-stable update
alexmcwhir...@triadic.us writes:
> On 2017-02-14 00:53, Jeremie Courreges-Anglas wrote:
>> Ian McWilliam <i.mcwill...@westernsydney.edu.au> writes:
>>
>>
>> I'm afraid that this diff is not the right direction. The reason why
>> we
>> keep using 4.4.5 is that a library was removed between 4.4.5 and 4.4.8,
>> so the diff as is probably doesn't package without a PLIST change.
>> Also
>> the removal of this shared lib means changes in other -stable ports and
>> a rebuild of the affected packages, instead of a simple upgrade of the
>> samba packages.
>>
>> I propose the following diff, which should allow people to use
>> samba-tool provision --use-ntvfs.
>>
>> There are bug fixes that have landed in samba-4.4 since 4.4.5, if
>> people
>> want to backport them because they break runtime, patches are welcome.
>>
>> Please test and report.
>>
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /d/cvs/ports/net/samba/Makefile,v
>> retrieving revision 1.227.2.1
>> diff -u -p -r1.227.2.1 Makefile
>> --- Makefile 23 Dec 2016 22:35:36 -0000 1.227.2.1
>> +++ Makefile 14 Feb 2017 05:45:09 -0000
>> @@ -15,7 +15,7 @@ PKGNAME-tevent = tevent-${TEVENT_V}
>> PKGNAME-util = samba-util-${VERSION}
>> PKGNAME-docs = samba-docs-${VERSION}
>>
>> -REVISION-main = 0
>> +REVISION-main = 1
>> REVISION-ldb = 0
>> REVISION-tevent = 0
>>
>> @@ -160,7 +160,8 @@ CONFIGURE_ARGS = --enable-fhs \
>> --without-regedit \
>> --without-acl-support \
>> --without-libarchive \
>> - --disable-rpath
>> + --disable-rpath \
>> + --with-ntvfs-fileserver
>>
>> # XXX Remember to remove --enable-developer, it prints passwords in
>> logs.
>> #CONFIGURE_ARGS += --enable-developer
>> Index: pkg/PLIST-main
>> ===================================================================
>> RCS file: /d/cvs/ports/net/samba/pkg/PLIST-main,v
>> retrieving revision 1.34
>> diff -u -p -r1.34 PLIST-main
>> --- pkg/PLIST-main 8 Jul 2016 18:39:50 -0000 1.34
>> +++ pkg/PLIST-main 14 Feb 2017 05:45:09 -0000
>> @@ -807,6 +807,7 @@ lib/samba/service/ldap.so
>> lib/samba/service/nbtd.so
>> lib/samba/service/ntp_signd.so
>> lib/samba/service/s3fs.so
>> +lib/samba/service/smb.so
^^^
This change was missing from the diffs I've seen.
>> lib/samba/service/web.so
>> lib/samba/service/winbindd.so
>> lib/samba/service/wrepl.so
>
> I'm fine with 4.4.5, but there really is no point in enabling ntvfs as
> it's broken plain and simple on all 4.4 releases.
Given the error message I've seen, it was probably broken because you
did't have the file above.
> Considering we have
> a workaround for using s3fs with tdb backends (a simple modification to
> a python script) i believe it would be much more beneficial to backport
> the s3fs workaround rather than enabling a broken file server.
I don't know whether ntvfs will stay around or not in the end, but if it
works fine in 6.0, this is enough for a backport.
If s3fs is actually usable if we "just" disable filesystem acl
operations, then the python script patch might be a good candidate
for -current (along with better documentation).
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
