DmitryJ added the comment:

Offending code in 2.7:

https://hg.python.org/cpython/file/20c9290a5de4/Objects/bytearrayobject.c#l2381
https://hg.python.org/cpython/file/20c9290a5de4/Objects/bytearrayobject.c#l2412

Let n = 16, where = 0; memmove() then attempts to copy (n - where) = 16 bytes 
where it should have copied 15, since we drop one. This appears to be a typical 
case of off-by-one. Changing (n - where) to (n - where - 1) should fix the 
issue. This underfows when (where + 1) > n, but this case is guarded against in 
bytearray_pop() and cannot occur in bytearray_remove().

The exact same memmove() invocation code is found in all 3.x branches as well.

----------
nosy: +dev_zzo

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue24467>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to