New submission from Martin Panter:

In /Lib/ctypes/test/test_values.py, three out of the five test cases are only 
run on Windows. There is a comment saying “This test only works when python 
itself is a dll/shared library”, and the tests run fine on Linux. So I propose 
to remove the Windows-only restriction, and rename the class from 
Win_ValuesTestCase to PythonValuesTestCase.

The immediate benefit for me is that I can see on Linux when I need to update 
one of those tests before I break a Windows builtbot :)

This test used to be completely disabled (probably by accident), and was 
enabled for Windows only in revision 6f63fff5c120. There was a comment 
<https://bugs.python.org/issue19493#msg206649> by Zach wondering if it 
shouldn’t be Windows-specific.

----------
components: Tests, ctypes
files: python-values.patch
keywords: patch
messages: 254623
nosy: martin.panter, zach.ware
priority: normal
severity: normal
stage: patch review
status: open
title: Enable ctypes.test.test_values.Win_ValuesTestCase for non-Windows
type: enhancement
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file41034/python-values.patch

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25622>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to