Cheryl Sabella <chek...@gmail.com> added the comment: I've made the changes requested. I wasn't sure about:
TESTFN_NONASCII - How different from TESTFN_UNICODE? Should I move these out of test.support?: missing_compiler_executable(cmd_names=[]) - It is used only in distutils tests and should be in distutils.tests.support. Matcher() - This class is used only in test_logging, and only with TestHandler. These classes should be documented together and with references to logging. I'm not sure they should be in test.support. TestHandler(logging.handlers.BufferingHandler) - I'm not sure it should be in test.support rather of test_logging. Thanks! ---------- stage: patch review -> _______________________________________ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32843> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
