New submission from Adam Goldschmidt <adamgo...@gmail.com>:
The urlparse module treats semicolon as a separator
(https://github.com/python/cpython/blob/master/Lib/urllib/parse.py#L739) -
whereas most proxies today only take ampersands as separators. Link to a blog
post explaining this vulnerability:
https://snyk.io/blog/cache-poisoning-in-popular-open-source-packages/
When the attacker can separate query parameters using a semicolon (;), they can
cause a difference in the interpretation of the request between the proxy
(running with default configuration) and the server. This can result in
malicious requests being cached as completely safe ones, as the proxy would
usually not see the semicolon as a separator, and therefore would not include
it in a cache key of an unkeyed parameter - such as `utm_*` parameters, which
are usually unkeyed. Let’s take the following example of a malicious request:
```
GET /?link=http://google.com&utm_content=1;link='><t>alert(1)</script> HTTP/1.1
Host: somesite.com
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/85.0.4183.83 Safari/537.36
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,imag
e/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9
Accept-Encoding: gzip, deflate
Accept-Language: en-US,en;q=0.9 Connection: close
```
urlparse sees 3 parameters here: `link`, `utm_content` and then `link` again.
On the other hand, the proxy considers this full string:
`1;link='><t>alert(1)</script>` as the value of `utm_content`, which is why the
cache key would only contain `somesite.com/?link=http://google.com`.
A possible solution could be to allow developers to specify a separator, like
werkzeug does:
https://github.com/pallets/werkzeug/blob/6784c44673d25c91613c6bf2e614c84465ad135b/src/werkzeug/urls.py#L833
----------
components: C API
messages: 385266
nosy: AdamGold
priority: normal
severity: normal
status: open
title: Web cache poisoning - `;` as a query args separator
type: security
versions: Python 3.10, Python 3.6, Python 3.7, Python 3.8, Python 3.9
_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue42967>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
