On 05/08/2015 02:06 PM, Eric Blake wrote: > On 05/08/2015 11:21 AM, Kevin Wolf wrote: >> Signed-off-by: Kevin Wolf <kw...@redhat.com> >> --- > > Might want to include mention of what it will be used for in the commit > body. > >> include/qapi/qmp/qdict.h | 1 + >> qobject/qdict.c | 68 >> +++++++++++++++++++++++++++++++++++++++++++++--- >> 2 files changed, 65 insertions(+), 4 deletions(-) >>
Oh, and I meant to mention: shouldn't the testsuite also be enhanced to cover the new functionality? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
