On Wed 03 Jun 2015 09:43:54 PM CEST, Max Reitz wrote: > BlockAcctStats contains statistics about the data transferred from and > to the device; wr_highest_sector does not fit in with the rest. > > Furthermore, those statistics are supposed to be specific for a certain > device and not necessarily for a BDS (see the comment above > bdrv_get_stats()); on the other hand, wr_highest_sector may be a rather > important information to know for each BDS. When BlockAcctStats is > finally removed from the BDS, we will want to keep wr_highest_sector in > the BDS. > > Finally, wr_highest_sector is renamed to wr_highest_offset and given the > appropriate meaning. Externally, it is represented as an offset so there > is no point in doing something different internally. Its definition is > changed to match that in qapi/block-core.json which is "the offset after > the greatest byte written to". Doing so should not cause any harm since > if external programs tried to calculate the volume usage by > (wr_highest_offset + 512) / volume_size, after this patch they will just > assume the volume to be full slightly earlier than before. > > Signed-off-by: Max Reitz <mre...@redhat.com>
Reviewed-by: Alberto Garcia <be...@igalia.com> Berto
