Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20180313161803.1814-1-kw...@redhat.com Subject: [Qemu-devel] [PULL 00/41] Block layer patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20180307082512.14203-1-be...@igalia.com -> patchew/20180307082512.14203-1-be...@igalia.com t [tag update] patchew/20180313153458.26822-1-peter.mayd...@linaro.org -> patchew/20180313153458.26822-1-peter.mayd...@linaro.org * [new tag] patchew/20180313161803.1814-1-kw...@redhat.com -> patchew/20180313161803.1814-1-kw...@redhat.com Switched to a new branch 'test' 73ceee78e6 block/mirror: change the semantic of 'force' of block-job-cancel 7363482c0a vpc: Require aligned size in .bdrv_co_create 2882d5ed9b vpc: Support .bdrv_co_create fc6a997d9c vhdx: Support .bdrv_co_create 20ef05f192 vdi: Make comments consistent with other drivers 459ee653e4 qed: Support .bdrv_co_create 8bba4791b7 qcow: Support .bdrv_co_create f64c119db2 qemu-iotests: Enable write tests for parallels 2080c0a1ab parallels: Support .bdrv_co_create 9faa105c59 iotests: Add regression test for commit base locking 6a296d9cfe block: Fix flags in reopen queue 781f48c549 vdi: Implement .bdrv_co_create 4cab0e18bb vdi: Move file creation to vdi_co_create_opts 891969da22 vdi: Pull option parsing from vdi_co_create 49280fb721 qemu-iotests: Test luks QMP image creation 0a4d72fa21 luks: Catch integer overflow for huge sizes 6fda8b9a38 luks: Turn invalid assertion into check c88dc7ac6e luks: Support .bdrv_co_create 681d5dff50 luks: Create block_crypto_co_create_generic() d641340c5a luks: Separate image file creation from formatting 8cae2fd8e8 tests/test-blockjob: test cancellations 1390b7c37d iotests: test manual job dismissal 1ad1823194 blockjobs: Expose manual property 55441ac858 blockjobs: add block-job-finalize 4a6e1bfbb0 blockjobs: add PENDING status and event ca394bb9c1 blockjobs: add waiting status 92017bd151 blockjobs: add prepare callback ef89eb33ad blockjobs: add block_job_txn_apply function 225d9d25ba blockjobs: add commit, abort, clean helpers 2de3034128 blockjobs: ensure abort is called for cancelled jobs 37ef0263ce blockjobs: add block_job_dismiss b59095a50b blockjobs: add NULL state 4c49f9fa27 blockjobs: add CONCLUDED state 7a4f169154 blockjobs: add ABORTING state ac30b7288c blockjobs: add block_job_verb permission table 068f7c2061 iotests: add pause_wait 8c386101bf blockjobs: add state transition table d8d8ffcb3d blockjobs: add status enum 99b5fa3cf0 Blockjobs: documentation touchup 318dc73f7e blockjobs: model single jobs as transactions 020497053e blockjobs: fix set-speed kick === OUTPUT BEGIN === Checking PATCH 1/41: blockjobs: fix set-speed kick... Checking PATCH 2/41: blockjobs: model single jobs as transactions... Checking PATCH 3/41: Blockjobs: documentation touchup... Checking PATCH 4/41: blockjobs: add status enum... Checking PATCH 5/41: blockjobs: add state transition table... ERROR: space prohibited before open square bracket '[' #82: FILE: blockjob.c:48: + /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #83: FILE: blockjob.c:49: + /* C: */ [BLOCK_JOB_STATUS_CREATED] = {0, 0, 1, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #84: FILE: blockjob.c:50: + /* R: */ [BLOCK_JOB_STATUS_RUNNING] = {0, 0, 0, 1, 1, 0}, ERROR: space prohibited before open square bracket '[' #85: FILE: blockjob.c:51: + /* P: */ [BLOCK_JOB_STATUS_PAUSED] = {0, 0, 1, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #86: FILE: blockjob.c:52: + /* Y: */ [BLOCK_JOB_STATUS_READY] = {0, 0, 0, 0, 0, 1}, ERROR: space prohibited before open square bracket '[' #87: FILE: blockjob.c:53: + /* S: */ [BLOCK_JOB_STATUS_STANDBY] = {0, 0, 0, 0, 1, 0}, total: 6 errors, 0 warnings, 88 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 6/41: iotests: add pause_wait... Checking PATCH 7/41: blockjobs: add block_job_verb permission table... Checking PATCH 8/41: blockjobs: add ABORTING state... ERROR: space prohibited before open square bracket '[' #65: FILE: blockjob.c:48: + /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #66: FILE: blockjob.c:49: + /* C: */ [BLOCK_JOB_STATUS_CREATED] = {0, 0, 1, 0, 0, 0, 1}, ERROR: space prohibited before open square bracket '[' #67: FILE: blockjob.c:50: + /* R: */ [BLOCK_JOB_STATUS_RUNNING] = {0, 0, 0, 1, 1, 0, 1}, ERROR: space prohibited before open square bracket '[' #68: FILE: blockjob.c:51: + /* P: */ [BLOCK_JOB_STATUS_PAUSED] = {0, 0, 1, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #69: FILE: blockjob.c:52: + /* Y: */ [BLOCK_JOB_STATUS_READY] = {0, 0, 0, 0, 0, 1, 1}, ERROR: space prohibited before open square bracket '[' #70: FILE: blockjob.c:53: + /* S: */ [BLOCK_JOB_STATUS_STANDBY] = {0, 0, 0, 0, 1, 0, 0}, ERROR: space prohibited before open square bracket '[' #71: FILE: blockjob.c:54: + /* X: */ [BLOCK_JOB_STATUS_ABORTING] = {0, 0, 0, 0, 0, 0, 0}, total: 7 errors, 0 warnings, 62 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/41: blockjobs: add CONCLUDED state... ERROR: space prohibited before open square bracket '[' #64: FILE: blockjob.c:48: + /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #65: FILE: blockjob.c:49: + /* C: */ [BLOCK_JOB_STATUS_CREATED] = {0, 0, 1, 0, 0, 0, 1, 0}, ERROR: space prohibited before open square bracket '[' #66: FILE: blockjob.c:50: + /* R: */ [BLOCK_JOB_STATUS_RUNNING] = {0, 0, 0, 1, 1, 0, 1, 1}, ERROR: space prohibited before open square bracket '[' #67: FILE: blockjob.c:51: + /* P: */ [BLOCK_JOB_STATUS_PAUSED] = {0, 0, 1, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #68: FILE: blockjob.c:52: + /* Y: */ [BLOCK_JOB_STATUS_READY] = {0, 0, 0, 0, 0, 1, 1, 1}, ERROR: space prohibited before open square bracket '[' #69: FILE: blockjob.c:53: + /* S: */ [BLOCK_JOB_STATUS_STANDBY] = {0, 0, 0, 0, 1, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #70: FILE: blockjob.c:54: + /* X: */ [BLOCK_JOB_STATUS_ABORTING] = {0, 0, 0, 0, 0, 0, 0, 1}, ERROR: space prohibited before open square bracket '[' #71: FILE: blockjob.c:55: + /* E: */ [BLOCK_JOB_STATUS_CONCLUDED] = {0, 0, 0, 0, 0, 0, 0, 0}, total: 8 errors, 0 warnings, 85 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 10/41: blockjobs: add NULL state... ERROR: space prohibited before open square bracket '[' #81: FILE: blockjob.c:48: + /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #82: FILE: blockjob.c:49: + /* C: */ [BLOCK_JOB_STATUS_CREATED] = {0, 0, 1, 0, 0, 0, 1, 0, 1}, ERROR: space prohibited before open square bracket '[' #83: FILE: blockjob.c:50: + /* R: */ [BLOCK_JOB_STATUS_RUNNING] = {0, 0, 0, 1, 1, 0, 1, 1, 0}, ERROR: space prohibited before open square bracket '[' #84: FILE: blockjob.c:51: + /* P: */ [BLOCK_JOB_STATUS_PAUSED] = {0, 0, 1, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #85: FILE: blockjob.c:52: + /* Y: */ [BLOCK_JOB_STATUS_READY] = {0, 0, 0, 0, 0, 1, 1, 1, 0}, ERROR: space prohibited before open square bracket '[' #86: FILE: blockjob.c:53: + /* S: */ [BLOCK_JOB_STATUS_STANDBY] = {0, 0, 0, 0, 1, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #87: FILE: blockjob.c:54: + /* X: */ [BLOCK_JOB_STATUS_ABORTING] = {0, 0, 0, 0, 0, 0, 0, 1, 0}, ERROR: space prohibited before open square bracket '[' #88: FILE: blockjob.c:55: + /* E: */ [BLOCK_JOB_STATUS_CONCLUDED] = {0, 0, 0, 0, 0, 0, 0, 0, 1}, ERROR: space prohibited before open square bracket '[' #89: FILE: blockjob.c:56: + /* N: */ [BLOCK_JOB_STATUS_NULL] = {0, 0, 0, 0, 0, 0, 0, 0, 0}, total: 9 errors, 0 warnings, 104 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 11/41: blockjobs: add block_job_dismiss... Checking PATCH 12/41: blockjobs: ensure abort is called for cancelled jobs... ERROR: space prohibited before open square bracket '[' #76: FILE: blockjob.c:54: + /* X: */ [BLOCK_JOB_STATUS_ABORTING] = {0, 0, 0, 0, 0, 0, 1, 1, 0}, total: 1 errors, 0 warnings, 58 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 13/41: blockjobs: add commit, abort, clean helpers... Checking PATCH 14/41: blockjobs: add block_job_txn_apply function... Checking PATCH 15/41: blockjobs: add prepare callback... Checking PATCH 16/41: blockjobs: add waiting status... ERROR: space prohibited before open square bracket '[' #81: FILE: blockjob.c:48: + /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #82: FILE: blockjob.c:49: + /* C: */ [BLOCK_JOB_STATUS_CREATED] = {0, 0, 1, 0, 0, 0, 0, 1, 0, 1}, ERROR: space prohibited before open square bracket '[' #83: FILE: blockjob.c:50: + /* R: */ [BLOCK_JOB_STATUS_RUNNING] = {0, 0, 0, 1, 1, 0, 1, 1, 0, 0}, ERROR: space prohibited before open square bracket '[' #84: FILE: blockjob.c:51: + /* P: */ [BLOCK_JOB_STATUS_PAUSED] = {0, 0, 1, 0, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #85: FILE: blockjob.c:52: + /* Y: */ [BLOCK_JOB_STATUS_READY] = {0, 0, 0, 0, 0, 1, 1, 1, 0, 0}, ERROR: space prohibited before open square bracket '[' #86: FILE: blockjob.c:53: + /* S: */ [BLOCK_JOB_STATUS_STANDBY] = {0, 0, 0, 0, 1, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #87: FILE: blockjob.c:54: + /* W: */ [BLOCK_JOB_STATUS_WAITING] = {0, 0, 0, 0, 0, 0, 0, 1, 1, 0}, ERROR: space prohibited before open square bracket '[' #88: FILE: blockjob.c:55: + /* X: */ [BLOCK_JOB_STATUS_ABORTING] = {0, 0, 0, 0, 0, 0, 0, 1, 1, 0}, ERROR: space prohibited before open square bracket '[' #89: FILE: blockjob.c:56: + /* E: */ [BLOCK_JOB_STATUS_CONCLUDED] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 1}, ERROR: space prohibited before open square bracket '[' #90: FILE: blockjob.c:57: + /* N: */ [BLOCK_JOB_STATUS_NULL] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, total: 10 errors, 0 warnings, 70 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 17/41: blockjobs: add PENDING status and event... ERROR: space prohibited before open square bracket '[' #85: FILE: blockjob.c:48: + /* U: */ [BLOCK_JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #86: FILE: blockjob.c:49: + /* C: */ [BLOCK_JOB_STATUS_CREATED] = {0, 0, 1, 0, 0, 0, 0, 0, 1, 0, 1}, ERROR: space prohibited before open square bracket '[' #87: FILE: blockjob.c:50: + /* R: */ [BLOCK_JOB_STATUS_RUNNING] = {0, 0, 0, 1, 1, 0, 1, 0, 1, 0, 0}, ERROR: space prohibited before open square bracket '[' #88: FILE: blockjob.c:51: + /* P: */ [BLOCK_JOB_STATUS_PAUSED] = {0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #89: FILE: blockjob.c:52: + /* Y: */ [BLOCK_JOB_STATUS_READY] = {0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 0}, ERROR: space prohibited before open square bracket '[' #90: FILE: blockjob.c:53: + /* S: */ [BLOCK_JOB_STATUS_STANDBY] = {0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #91: FILE: blockjob.c:54: + /* W: */ [BLOCK_JOB_STATUS_WAITING] = {0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0}, ERROR: space prohibited before open square bracket '[' #92: FILE: blockjob.c:55: + /* D: */ [BLOCK_JOB_STATUS_PENDING] = {0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0}, ERROR: space prohibited before open square bracket '[' #93: FILE: blockjob.c:56: + /* X: */ [BLOCK_JOB_STATUS_ABORTING] = {0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0}, ERROR: space prohibited before open square bracket '[' #94: FILE: blockjob.c:57: + /* E: */ [BLOCK_JOB_STATUS_CONCLUDED] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1}, ERROR: space prohibited before open square bracket '[' #95: FILE: blockjob.c:58: + /* N: */ [BLOCK_JOB_STATUS_NULL] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, total: 11 errors, 0 warnings, 185 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 18/41: blockjobs: add block-job-finalize... Checking PATCH 19/41: blockjobs: Expose manual property... Checking PATCH 20/41: iotests: test manual job dismissal... Checking PATCH 21/41: tests/test-blockjob: test cancellations... Checking PATCH 22/41: luks: Separate image file creation from formatting... Checking PATCH 23/41: luks: Create block_crypto_co_create_generic()... Checking PATCH 24/41: luks: Support .bdrv_co_create... Checking PATCH 25/41: luks: Turn invalid assertion into check... Checking PATCH 26/41: luks: Catch integer overflow for huge sizes... Checking PATCH 27/41: qemu-iotests: Test luks QMP image creation... Checking PATCH 28/41: vdi: Pull option parsing from vdi_co_create... Checking PATCH 29/41: vdi: Move file creation to vdi_co_create_opts... Checking PATCH 30/41: vdi: Implement .bdrv_co_create... Checking PATCH 31/41: block: Fix flags in reopen queue... Checking PATCH 32/41: iotests: Add regression test for commit base locking... Checking PATCH 33/41: parallels: Support .bdrv_co_create... Checking PATCH 34/41: qemu-iotests: Enable write tests for parallels... Checking PATCH 35/41: qcow: Support .bdrv_co_create... Checking PATCH 36/41: qed: Support .bdrv_co_create... Checking PATCH 37/41: vdi: Make comments consistent with other drivers... Checking PATCH 38/41: vhdx: Support .bdrv_co_create... Checking PATCH 39/41: vpc: Support .bdrv_co_create... Checking PATCH 40/41: vpc: Require aligned size in .bdrv_co_create... Checking PATCH 41/41: block/mirror: change the semantic of 'force' of block-job-cancel... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org