Jonathan Cameron wrote: > On Mon, 18 Sep 2023 17:31:38 +0100 > Peter Maydell <peter.mayd...@linaro.org> wrote: > > > On Mon, 18 Sept 2023 at 16:04, Jonathan Cameron > > <jonathan.came...@huawei.com> wrote: > > > > > > This has been missing from the start. Assume it should match > > > with cxl/cxl-component-utils.c as both were part of early > > > postings from Ben. > > > > Sounds plausible -- is there an Intel person who could give us > > an acked-by for this?
While we are at it; what about .../hw/mem/cxl_type3_stubs.c? > > > > (Ideally we wouldn't have let more gpl-2-only code into the > > codebase without a rationale...) I'm curious about this statement. Does the qemu project not want gpl v2 only code? I agree with Jonathan that this is the intention of Ben's initial submission; so from that PoV. Acked-by: Ira Weiny <ira.we...@intel.com> Going forward I'd like to better understand the qemu communities view. Thanks, Ira > > > > I've +CC'd the kernel CXL maintainers from Intel a few of whom > have also contributed some of the QEMU CXL code. > Hopefully someone can ack. > > > > Suggested-by: Philippe Mathieu-Daudé <phi...@linaro.org> > > > Signed-off-by: Jonathan Cameron <jonathan.came...@huawei.com> > > > --- > > > hw/mem/cxl_type3.c | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c > > > index c5855d4e7d..ad3f0f6a9d 100644 > > > --- a/hw/mem/cxl_type3.c > > > +++ b/hw/mem/cxl_type3.c > > > @@ -1,3 +1,12 @@ > > > +/* > > > + * CXL Type 3 (memory expander) device > > > + * > > > + * Copyright(C) 2020 Intel Corporation. > > > + * > > > + * This work is licensed under the terms of the GNU GPL, version 2. See > > > the > > > + * COPYING file in the top-level directory. > > > + */ > > > + > > > #include "qemu/osdep.h" > > > #include "qemu/units.h" > > > #include "qemu/error-report.h" > > > > -- PMM > > >
