Your message dated Fri, 22 Mar 2024 09:52:58 +0000
with message-id <e1rnba6-00fmls...@fasolo.debian.org>
and subject line Bug#1066991: fixed in diffoscope 261
has caused the Debian Bug report #1066991,
regarding easy way to crash diffoscope
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1066991: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066991
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
package: diffoscope
version: 240

hi,

crashing diffoscope in under 2min (the package build takes 42sec here).

$ apt source golang-github-stvp-tempredis 
$ sudo pbuilder build golang-github-stvp-tempredis_0.0~git20231107.8a695b6-1.dsc
$ mkdir p1 ; mv /var/cache/pbuilder/unstable/result/* p1/
$ sudo pbuilder build golang-github-stvp-tempredis_0.0~git20231107.8a695b6-1.dsc
$ mkdir p2 ; mv /var/cache/pbuilder/unstable/result/* p2/
$ diffoscope 
p1/golang-github-stvp-tempredis_0.0~git20231107.8a695b6-1_amd64.changes 
p2/golang-github-stvp-tempredis_0.0~git20231107.8a695b6-1_amd64.changes 
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 767, in main
    sys.exit(run_diffoscope(parsed_args))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 718, in 
run_diffoscope
    difference = compare_root_paths(path1, path2)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 
69, in compare_root_paths
    difference = compare_files(file1, file2)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 
149, in compare_files
    return file1.compare(file2, source)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/debian.py", line 
275, in compare
    differences = super().compare(other, *args, **kwargs)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 532, in compare
    difference = self._compare_using_details(other, source)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 467, in _compare_using_details
    details.extend(
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", 
line 197, in compare_pair
    difference = compare_files(
                 ^^^^^^^^^^^^^^
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 
149, in compare_files
    return file1.compare(file2, source)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 532, in compare
    difference = self._compare_using_details(other, source)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 467, in _compare_using_details
    details.extend(
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", 
line 197, in compare_pair
    difference = compare_files(
                 ^^^^^^^^^^^^^^
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 
149, in compare_files
    return file1.compare(file2, source)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 532, in compare
    difference = self._compare_using_details(other, source)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 467, in _compare_using_details
    details.extend(
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", 
line 197, in compare_pair
    difference = compare_files(
                 ^^^^^^^^^^^^^^
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 
149, in compare_files
    return file1.compare(file2, source)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 532, in compare
    difference = self._compare_using_details(other, source)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 467, in _compare_using_details
    details.extend(
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/container.py", 
line 197, in compare_pair
    difference = compare_files(
                 ^^^^^^^^^^^^^^
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 
149, in compare_files
    return file1.compare(file2, source)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 532, in compare
    difference = self._compare_using_details(other, source)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", 
line 433, in _compare_using_details
    details.extend(self.compare_details(other, source))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/rdata.py", line 
166, in compare_details
    a = get_module_path_for_rdb(self, tmpdir, "a")
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/diffoscope/comparators/rdata.py", line 
99, in get_module_path_for_rdb
    rdx = rdb.container.get_member(rdx_name)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File 
"/usr/lib/python3/dist-packages/diffoscope/comparators/utils/libarchive.py", 
line 283, in get_member
    raise KeyError(f"{member_name} not found in archive")
KeyError: './usr/share/gocode/src/github.com/stvp/tempredis/dump.rdx not found 
in archive'
$ echo $?
2

This happens with both diffoscope in stable and unstable.

Noticed via https://tests.reproducible-builds.org/debian/index_breakages.html


-- 
cheers,
        Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

I'm looking forward to Corona being a beer again and Donald a duck.

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: diffoscope
Source-Version: 261
Done: Chris Lamb <la...@debian.org>

We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1066...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <la...@debian.org> (supplier of updated diffoscope package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 22 Mar 2024 09:42:15 +0000
Source: diffoscope
Built-For-Profiles: nocheck
Architecture: source
Version: 261
Distribution: unstable
Urgency: medium
Maintainer: Reproducible builds folks 
<reproducible-bui...@lists.alioth.debian.org>
Changed-By: Chris Lamb <la...@debian.org>
Closes: 1066991
Changes:
 diffoscope (261) unstable; urgency=medium
 .
   [ Chris Lamb ]
   * Don't crash if we encounter an .rdb file without an equivalent .rdx file.
     (Closes: #1066991)
   * In addition, don't identify Redis database dumps (etc.) as GNU R database
     files based simply on their filename. (Re: #1066991)
   * Update copyright years.
Checksums-Sha1:
 b1c26ea503d055db7ee0b6f8acbfeeed0d0ba090 5173 diffoscope_261.dsc
 a34d4eaa1f1a548a7bf833a1522b7c32c24d4856 2454992 diffoscope_261.tar.xz
 16dc6a2c25225f45b7c81bcfdfd7f9a59e59a5f1 7257 diffoscope_261_amd64.buildinfo
Checksums-Sha256:
 9e70986332edac4dafeac8006ae170804ff20440850b2e2ffa47f18ff826bd9b 5173 
diffoscope_261.dsc
 faf12df305fddc546efe07e245acd36cc275e8c84839351db9c4628bfca5d2aa 2454992 
diffoscope_261.tar.xz
 1b1dcf6911b8e0f87d54c859c48cbbf70ce8a8729bdfa030d11c06988aff7eb2 7257 
diffoscope_261_amd64.buildinfo
Files:
 04d1520a8435aae5de1ff0d3908cb086 5173 devel optional diffoscope_261.dsc
 4a4f0b7003911c925f07878523ead0ce 2454992 devel optional diffoscope_261.tar.xz
 3a45b957b8ccc574d4841767c0fce0d4 7257 devel optional 
diffoscope_261_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmX9UqgACgkQHpU+J9Qx
HlgtTA/+OzmaQynj4j/sPscMLdxFl2xJKFvaEvGaNYDMqclEthniRSfUrYlAsEDp
f2wzr/NDzoH7dM8j7Nf58ZtcKQn3VmIpWgEqEhHOIXXqZss55P/8kkjhf22hBYpN
u4dfWe2cdJHpgegkuo2Zg7Y8ZC/OutYCE3cZ2//xv2OYCGv2D7C5btz1+s7vCytK
kd9tfzlRgzl5SWg0ob2Hsr+IoyOyMewMwLg2XDDKVIg17ItY0cLy3U6Wdgr3Etia
3QSw6Tk1oA+5RLk00mNmC/7rhn/t6F2K1LpvRmxN75gmLDzXQDMqhpsvC4uRMwzc
1jhlyx0nApPWKm672xXaIphEKnZW6Gb7UB91+tsXE2Y/zZFzrYJbH5042BeFci/m
lFMHTm3cNBj+lZZb+9S7fhsYudS+Mespb0TMUjFdKr/UilAu7w7J7aSUSmr3TdJ2
ZtNFpgK028m3V4OBeQ9W3LQmYjLIbbdle8sJbDTErJK/kOzGBq0M+WougQyaoYHN
4jK9RhFBhiP5yRxwwpa1zawRksz7wpFb0PJvup0dJBwyA5ImYZ3HFetb/9sMfk2W
qAOHsSzIxNyBKMuCmn3B+5QUVZ9MKQ/+xrSNuwxYxg/5Dj8SnC5d35KJJ50bYNrH
IFchVvi74NH/6xudC6b+60zgYNQtv8Skd+12S5w4i7blPxbbVXk=
=Hsqr
-----END PGP SIGNATURE-----

Attachment: pgpavwpWB_KVK.pgp
Description: PGP signature


--- End Message ---
_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to