Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13525 )
Change subject: IMPALA-8551: Bump CDP_BUILD_NUMBER to 1153860 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13525/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/13525/2/tests/authorization/test_ranger.py@566 PS2, Line 566: invalid_impala_client, : statement, : user=invalid_user) it's weird that you need two different clients, but you're passing the user info here in the query instead of in the client creation. I guess this is probably a weird artifact of the test client code or something? Would it be straight-forward to refactor/fix this? If not, mind adding some comment explaining what's going on here? http://gerrit.cloudera.org:8080/#/c/13525/2/tests/authorization/test_ranger.py@578 PS2, Line 578: HTTP 403 Error is there any way we can get rid of the HTTP error part of the error message? This seems very specific to the underlying implementation of ranger and just confusing to a user -- To view, visit http://gerrit.cloudera.org:8080/13525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8995f5dc88b211cd3af415713802cfeac44fe576 Gerrit-Change-Number: 13525 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 07 Jun 2019 05:05:48 +0000 Gerrit-HasComments: Yes
