Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 )
Change subject: fe: improve logging for metadata loading ...................................................................... Patch Set 1: (7 comments) patch set r2 has fixes for the comments. r3 will rebase to tip of master http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1954 PS1, Line 1954: why > will do Done http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@103 PS1, Line 103: hiveexec > mistake -- eclipse loves to auto-import shaded crap :( Done http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@628 PS1, Line 628: new Exception() > yea, this was some debugging junk I left in by mistake Done http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@891 PS1, Line 891: org.apache.hadoop.hive.metastore.api.Table msTbl, String why) throws TableLoadingException { > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@813 PS1, Line 813: insert > would be used to say processing table-level insert event from HMS for consi Done http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@170 PS1, Line 170: assertNotNull(catalog_.getOrLoadTable(hbaseDb.getName(), "alltypessmallbinary", "test")); > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@172 PS1, Line 172: assertNotNull(catalog_.getOrLoadTable(hbaseDb.getName(), "hbasealltypeserror", "test")); > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/13463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d90a5f075b05d2dc96692b3349abe35ce24b8b8 Gerrit-Change-Number: 13463 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Jun 2019 20:23:24 +0000 Gerrit-HasComments: Yes
