Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 )
Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) +2 pending one issue with the DCHECK http://gerrit.cloudera.org:8080/#/c/13818/1/be/src/rpc/rpc-mgr.inline.h File be/src/rpc/rpc-mgr.inline.h: http://gerrit.cloudera.org:8080/#/c/13818/1/be/src/rpc/rpc-mgr.inline.h@44 PS1, Line 44: DCHECK(!IsResolvedAddress(MakeNetworkAddress(hostname))) << hostname << "\n" I don't think this DCHECK is valid -- it's OK to run things in an environment without DNS, if you give the hosts principals like impala/1.2.3.4. -- To view, visit http://gerrit.cloudera.org:8080/13818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85b661c8c3b3b67bfc1ce9e29aecb90a862666c0 Gerrit-Change-Number: 13818 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 09 Jul 2019 03:33:20 +0000 Gerrit-HasComments: Yes
