Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15559 )
Change subject: rowblock: improve GetSelectedRows API ...................................................................... rowblock: improve GetSelectedRows API The earlier commit used a boolean return value to indicate whether all rows were selected, but as I used the API more, I found the code somewhat confusing. This adds a wrapper class with appropriate getters and error checking. Change-Id: I34630c7bb854cca572ec081acbc05f3dac4db931 Reviewed-on: http://gerrit.cloudera.org:8080/15559 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <aw...@cloudera.com> --- M src/kudu/common/rowblock-test.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h M src/kudu/common/wire_protocol.cc 4 files changed, 89 insertions(+), 33 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I34630c7bb854cca572ec081acbc05f3dac4db931 Gerrit-Change-Number: 15559 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
