Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15690 )
Change subject: net: make Sockaddr more generic for other address families ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15690/3/src/kudu/util/net/net_util-test.cc File src/kudu/util/net/net_util-test.cc: http://gerrit.cloudera.org:8080/#/c/15690/3/src/kudu/util/net/net_util-test.cc@232 PS3, Line 232: ASSERT_TRUE(uninitialized_1 == uninitialized_2); : : Sockaddr wildcard = Sockaddr::Wildcard(); : ASSERT_FALSE(wildcard == uninitialized_1); : ASSERT_FALSE(uninitialized_1 == wildcard); : : Sockaddr wildcard_2 = Sockaddr::Wildcard(); : ASSERT_TRUE(wildcard == wildcard_2); : ASSERT_TRUE(wildcard_2 == wildcard); : : Sockaddr ip_port; : ASSERT_OK(ip_port.ParseString("127.0.0.1:12345", 0)); : ASSERT_FALSE(ip_port == uninitialized_1); : ASSERT_FALSE(ip_port == wildcard); : ASSERT_TRUE(ip_port == ip_port); > nit: any reason to not use ASSERT_EQ and ASSERT_NE for these? that requires defining either an operator<< or some kind of gtest printer method for Sockaddr, and I was too lazy to do that http://gerrit.cloudera.org:8080/#/c/15690/3/src/kudu/util/net/sockaddr.h File src/kudu/util/net/sockaddr.h: http://gerrit.cloudera.org:8080/#/c/15690/3/src/kudu/util/net/sockaddr.h@134 PS3, Line 134: // Set the type of the internal storage to 'family' and adjust ASAN poisoning : // appropriately. > nit: meant for another method? Ack -- To view, visit http://gerrit.cloudera.org:8080/15690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifff57e13a0e9b86b191d776ead67371b1e2ed4e3 Gerrit-Change-Number: 15690 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Tue, 14 Apr 2020 16:13:32 +0000 Gerrit-HasComments: Yes
