Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15802 )
Change subject: KUDU-2844 (3/3): avoid copying plain/dict strings to RowBlock Arena ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15802/2/src/kudu/common/rowblock_memory.h File src/kudu/common/rowblock_memory.h: http://gerrit.cloudera.org:8080/#/c/15802/2/src/kudu/common/rowblock_memory.h@51 PS2, Line 51: item->AddRef(); > Why we do not use std::shared_ptr ? I wasn't sure how to do the appropriate type erasure in that circumstance. I can give it a try, though. -- To view, visit http://gerrit.cloudera.org:8080/15802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93fa1f9fd401814a42dc5a1f3fd2ffb1286ac441 Gerrit-Change-Number: 15802 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Apr 2020 23:41:10 +0000 Gerrit-HasComments: Yes
