Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 )
Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/block_handle.h File src/kudu/cfile/block_handle.h: http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/block_handle.h@39 PS1, Line 39: nit: extra space http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/block_handle.h@64 PS1, Line 64: : boost::variant<BlockCacheHandle, scoped_refptr<BlockHandle>> ref_; : Slice data_; : bool is_data_owner_; : nit: mind moving these below the methods? -- To view, visit http://gerrit.cloudera.org:8080/15800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1077fcc841ca31a2cb523769fffeed2d27782bc1 Gerrit-Change-Number: 15800 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Fri, 01 May 2020 05:24:27 +0000 Gerrit-HasComments: Yes
