Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16060 )
Change subject: [tests] add same_tablet_concurrent_writes test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16060/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16060/2//COMMIT_MSG@24 PS2, Line 24: The rates of successful write operations was the same for both cases. : However, the number of messages from spinlock_profiling.cc like : Waited 190 ms on lock 0x237acd4 ... : dropped significantly after applying patch 16034 on top. That's a good : news to have less contention because the freed CPU resources might be : spend on something useful. can you compare a latency histogram, either from the point of view of the client, or using the existing latency histogram metrics? (eg on the Write RPC or the prepare/apply time histos?) or if you are claiming a CPU reduction, measure CPU cycles per completed write using perf-stat on a before/after? -- To view, visit http://gerrit.cloudera.org:8080/16060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7eef6e46e7685450354473cee9d804c5054723eb Gerrit-Change-Number: 16060 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 10 Jun 2020 22:12:08 +0000 Gerrit-HasComments: Yes
