Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15971 )
Change subject: [master] cache for table locations ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15971/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15971/3//COMMIT_MSG@14 PS3, Line 14: A smaller 12% improvement is observed for GetTableLocations RPC Not to be too much of a downer, but is this complexity worth it for 12% end-to-end? As I understand it, the 12% is for the case when all the clients are sending the exact same request, which may not be the case in real scenarios, right? (eg each task is likely to be asking for the locations of a different partition in the case of a query) -- To view, visit http://gerrit.cloudera.org:8080/15971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d2a4771ddc455d92a1da00db91c555a21151a23 Gerrit-Change-Number: 15971 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 30 Jun 2020 05:18:58 +0000 Gerrit-HasComments: Yes