Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16189 )
Change subject: client: allocate InFlightOp from a Batcher Arena ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16189/1/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: http://gerrit.cloudera.org:8080/#/c/16189/1/src/kudu/client/batcher.cc@379 PS1, Line 379: int ifo_prefetch = i + kPrefetchDistance * 3; : int op_prefetch = i + kPrefetchDistance * 2; : int row_prefetch = i + kPrefetchDistance; : if (ifo_prefetch >= 0 && ifo_prefetch < size) { : __builtin_prefetch(ops_[ifo_prefetch], 0, PREFETCH_HINT_T0); : } : if (op_prefetch >= 0 && op_prefetch < size) { : const auto* op = ops_[op_prefetch]->write_op.get(); : if (op) { : __builtin_prefetch(&op->row().isset_bitmap_, 0, PREFETCH_HINT_T0); : } : } : if (row_prefetch >= 0 && row_prefetch < size) { : const auto* op = ops_[row_prefetch]->write_op.get(); : if (op) { : __builtin_prefetch(op->row().isset_bitmap_, 0, PREFETCH_HINT_T0); : } Just making sure I understand this bit: while ops_ are all allocated in the arena, the underlying KuduWriteOps may still strewn strewn about since they're allocated by clients, which makes this optimization still valuable, right? -- To view, visit http://gerrit.cloudera.org:8080/16189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446a8d21253b7a274872bff6d3e76705ac95d0d5 Gerrit-Change-Number: 16189 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 14 Jul 2020 01:15:08 +0000 Gerrit-HasComments: Yes
