Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16200 )
Change subject: add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16200/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16200/1//COMMIT_MSG@7 PS1, Line 7: add setErrorCollectorSpace method to change ErrorCollector size, in case errors are dropped in manual flush mode nit: line too long http://gerrit.cloudera.org:8080/#/c/16200/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: PS1: This approach seems a bit weird to me. Wouldn't it be better to allow specifying the error collector size when instantiating the session? Alternatively, we could allow changing the error collector size by doing a thread safe copy of the queues contents on resize. Either way, we could leave the errorCollector final. http://gerrit.cloudera.org:8080/#/c/16200/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@229 PS1, Line 229: throw new IllegalArgumentException("Cannot change error collector size when error collecor is not empty"); nit: line too long -- To view, visit http://gerrit.cloudera.org:8080/16200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f04ff923fe53b28d1c54594948d660846331573 Gerrit-Change-Number: 16200 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <guanwen...@taptap.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Jul 2020 13:32:48 +0000 Gerrit-HasComments: Yes
