Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16209 )
Change subject: tls_socket: avoid cork/uncork dance for small writevs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/16209/1/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: http://gerrit.cloudera.org:8080/#/c/16209/1/src/kudu/security/tls_socket.cc@134 PS1, Line 134: // TODO(todd) why int32 in once place and int64 in the other? Now I'm curious, did you mean to add a comment here explaining this? Or is this something that makes it perform better but you're yet to figure out why? -- To view, visit http://gerrit.cloudera.org:8080/16209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6abf790a38878b41862655e643782a7624b763f Gerrit-Change-Number: 16209 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 17 Jul 2020 00:17:47 +0000 Gerrit-HasComments: Yes
