Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16332 )
Change subject: WIP KUDU-1587 part 1: load meter for ThreadPool ...................................................................... Patch Set 1: just did a quick skim over the patch, would be good to get someone to review in more detail. Generally it seems reasonable, I think the concerns would be: (1) if not enabled, confirm that this doesn't add any noticeable overhead (2) if enabled, measure how much overhead this adds (eg does the threadpool become noticeably less scalable due to more work happening under the threadpool lock?) Also might make sense to hold off on committing this until the later patch(es) in the series that make use of it prove out that it effectively solves the KUDU-1587 issue. I had sketched out the "overload detection" solution on the JIRA but I don't know if it will work in practice :) -- To view, visit http://gerrit.cloudera.org:8080/16332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640716dc32f193e68361ca623ee7b9271e661d8b Gerrit-Change-Number: 16332 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 12 Aug 2020 23:09:37 +0000 Gerrit-HasComments: No
