Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 )
Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted ...................................................................... Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/15800/3/src/kudu/cfile/block_handle.h File src/kudu/cfile/block_handle.h: http://gerrit.cloudera.org:8080/#/c/15800/3/src/kudu/cfile/block_handle.h@23 PS3, Line 23: #include <boost/none.hpp> nit: I'm surprised this was needed. Is it a remnant from before using Uninitialized(), or is this actually necessary by virtue of using boost::get<> or something? http://gerrit.cloudera.org:8080/#/c/15800/3/src/kudu/cfile/block_handle.h@64 PS3, Line 64: thie nit: this http://gerrit.cloudera.org:8080/#/c/15800/2/src/kudu/cfile/block_handle.h File src/kudu/cfile/block_handle.h: http://gerrit.cloudera.org:8080/#/c/15800/2/src/kudu/cfile/block_handle.h@94 PS2, Line 94: ref_ = Uninitialized{}; > I convinced myself to go back to scoped_refptr here, and also made another Thanks! -- To view, visit http://gerrit.cloudera.org:8080/15800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1077fcc841ca31a2cb523769fffeed2d27782bc1 Gerrit-Change-Number: 15800 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Aug 2020 21:56:00 +0000 Gerrit-HasComments: Yes
