ulysses-you commented on a change in pull request #30368:
URL: https://github.com/apache/spark/pull/30368#discussion_r523666452
##########
File path:
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q92/explain.txt
##########
@@ -1,5 +1,5 @@
== Physical Plan ==
-TakeOrderedAndProject (34)
+* Sort (34)
Review comment:
Other thought, we can add this pattern
```
case sort @ Sort(order, true, child)
if sort.maxRow < conf.topKSortFallbackThreshold =>
TakeOrderedAndProjectExec()
```
In this way, we can infer the `TakeOrderedAndProjectExec` from `Sort` which
has not `Limit` after.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
