dongjoon-hyun commented on a change in pull request #30379:
URL: https://github.com/apache/spark/pull/30379#discussion_r523670660
##########
File path: sql/core/benchmarks/SubExprEliminationBenchmark-jdk11-results.txt
##########
@@ -0,0 +1,15 @@
+================================================================================================
+Benchmark for performance of subexpression elimination
+================================================================================================
+
+Preparing data for benchmarking ...
+OpenJDK 64-Bit Server VM 11.0.9+11 on Mac OS X 10.15.6
+Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
+from_json as subExpr: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
+-------------------------------------------------------------------------------------------------------------------------
+subexpressionElimination off, codegen on 26809 27731
898 0.0 268094225.4 1.0X
+subexpressionElimination off, codegen off 25117 26612
1357 0.0 251166638.4 1.1X
+subexpressionElimination on, codegen on 2582 2906
282 0.0 25819408.7 10.4X
Review comment:
Wow. It's faster in Java11?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
