dongjoon-hyun commented on a change in pull request #30283:
URL: https://github.com/apache/spark/pull/30283#discussion_r523704833
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
##########
@@ -177,4 +190,34 @@ private[k8s] class LoggingPodStatusWatcherImpl(
private def formatTime(time: String): String = {
if (time != null || time != "") time else "N/A"
}
+
+ override def watchOrStop(sId: String): Boolean = if (waitForCompletion) {
+ logInfo(s"Waiting for application ${conf.appName} with submission ID $sId
to finish...")
+ val interval = maybeLoggingInterval
+
+ synchronized {
+ while (!podCompleted && !resourceTooOldReceived) {
+ wait(interval.get)
+ logInfo(s"Application status for $appId (phase: $phase)")
+ }
+ }
+
+ if(podCompleted) {
+ logInfo(
+ pod.map { p => s"Container final
statuses:\n\n${containersDescription(p)}" }
+ .getOrElse("No containers were found in the driver pod."))
+ logInfo(s"Application ${appId} with submission ID $sId finished")
+ } else {
+ logInfo(s"Got HTTP Gone code, resource version changed in k8s api.
Creating a new watcher.")
+ }
+
+ logInfo(s"Watcher has stopped, pod completed status: ${podCompleted}")
+
+ podCompleted
+ } else {
+ logInfo(s"Deployed Spark application ${appId} with submission ID $sId into
Kubernetes")
Review comment:
Instead of `${appId}`, the other branches seem to use `${conf.appName}`,
don't they?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
