ulysses-you commented on a change in pull request #32872:
URL: https://github.com/apache/spark/pull/32872#discussion_r665031937
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1567,7 +1567,7 @@ class AdaptiveQueryExecSuite
assert(!smj.head.isSkewJoin)
// Both sides are coalesced.
val customReaders = collect(smj.head) {
- case c: CustomShuffleReaderExec if c.hasCoalescedPartition => c
+ case c: CustomShuffleReaderExec => c
Review comment:
I think here have two things:
1. hasCoalescedPartition; `CustomShuffleReaderExec` has some
`CoalescedPartitionSpec`
2. coalesced; `CoalescedPartitionSpec` has some coalesced partition (exists
`startReducerIndex + 1 != endReducerIndex`)
The `stringArgs` method we want to change is for option 2, so I think is it
better to create new method `coalesced` to make them clearly ? cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
